Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves BQ transforms outside of recipe.py and imports from outside module #61

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

norlandrhagen
Copy link
Contributor

@norlandrhagen norlandrhagen commented Nov 13, 2023

Since pangeo-forge/pangeo-forge-runner#92 isn't quite done, this provides a work around to move all the Big Query transforms and table creation outside of the feedstock into a mini helper repo.

#39

@jbusecke
Copy link
Collaborator

Hey @norlandrhagen thanks for tackling these. I am debating internally if it is better to have another repo or make cmip6-feedstock installable/publish it on pypi. Are you planning to reuse these things outside of the CMIP context?

@norlandrhagen
Copy link
Contributor Author

Some of the utilities could be used for cataloging, but don't feel super strongly if you want to go with the cmip6-feedstock pypi route.

@jbusecke
Copy link
Collaborator

I think this will actually help with #63, so let's move ahead here. We can always refactor things as needed later.

@jbusecke
Copy link
Collaborator

jbusecke commented Nov 16, 2023

Oh weird. The Google auth does not work...wondering if this is because the PR branch is from another org?

values via GitHub secrets, ensure the secret is being injected into the environment. By default, secrets are not passed to workflows triggered from forks, including Dependabot.

ummm not sure how to get around this...

@jbusecke jbusecke changed the base branch from main to merge_bq November 16, 2023 23:59
@jbusecke jbusecke merged commit 28935e8 into leap-stc:merge_bq Nov 16, 2023
1 check failed
jbusecke added a commit that referenced this pull request Nov 17, 2023
…o-forge-big-query with credentials (#66)

* moves BQ transforms outside of recipe.py and imports from pangeo-forge-big-query (#61)

Co-authored-by: Julius Busecke <julius@ldeo.columbia.edu>

* Update recipe.py

---------

Co-authored-by: Raphael Hagen <norlandrhagen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants