Fix magit-section usage so the expand/contract functionality works #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bustercopley
force-pushed
the
magit-section
branch
from
01a6d77
to
f21999a
Compare
|
force-push: rebase onto #51 |
Use named sections so magit-section can track which sections are expanded. Don't use sections for individual diagnostics, since they can't be tracked. Capture data in lexicals for deferred rendering by `magit-insert-section-body'. Use `with-current-buffer` (delete `lean4-with-info-output-to-buffer`). Make the diagnostic `line:col` headers into text buttons.
bustercopley
force-pushed
the
magit-section
branch
from
f21999a
to
7e7577e
Compare
|
Rebased onto leanprover-community:master |
|
Can someone merge this please? |
|
I see no reason not to. It's just a minor bugfix. @sebeaumont, please ping Yury (@urkud) on Zulip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use named sections so magit-section can track which sections are expanded.
Don't use sections for individual diagnostics, since they can't be tracked.
Capture data in lexicals for deferred rendering by
magit-insert-section-body.Use
with-current-buffer(deletelean4-with-info-output-to-buffer).Make the diagnostic
line:colheaders into text buttons.