Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adaptations for leanprover/lean4#2714 #81

Closed
wants to merge 1 commit into from

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Oct 26, 2023

This has already been merged in nightly-testing, but I would like an approval in time for the next Lean version release next week if possible.

kim-em added a commit that referenced this pull request Oct 26, 2023
@kim-em kim-em added v4.3.0-rc1 This PR needs to wait until we move to `v4.3.0-rc1`. It will be merged to `nightly-testing` first. merged-into-nightly-testing This has been merged into `nightly-testing`, and will join `master` when we update the toolchain. labels Oct 26, 2023
@JLimperg
Copy link
Collaborator

What is this nightly-testing exactly? A staging branch for the next Lean release?

@JLimperg
Copy link
Collaborator

The actual change is obviously fine. One test seems to be broken (and std as well), but the breakage seems to be trivial and unrelated to this change.

@kim-em
Copy link
Collaborator Author

kim-em commented Oct 26, 2023

What is this nightly-testing exactly? A staging branch for the next Lean release?

Sorry, yes, it's a branch of aesop that Mathlib's nightly-testing can depend on, and includes all patches for Lean PRs that have landed in nightlies but not yet joined a release that aesop will bump to.

@kim-em
Copy link
Collaborator Author

kim-em commented Oct 26, 2023

I don't really have a solution at present for working CI for these sort of PRs. :-(

@JLimperg
Copy link
Collaborator

Superseded by #83.

@JLimperg JLimperg closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-into-nightly-testing This has been merged into `nightly-testing`, and will join `master` when we update the toolchain. v4.3.0-rc1 This PR needs to wait until we move to `v4.3.0-rc1`. It will be merged to `nightly-testing` first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants