Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CID-2087] Generate CycloneDX v1.5 Sbom files #68

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

ahmed-ali-55
Copy link
Contributor

@ahmed-ali-55 ahmed-ali-55 commented Nov 24, 2023

Jira: CID-2087

🛠 Changes made

  1. Removing CycloneDx=schema.version from ORT report params.
  2. Upgrading cyclonedx-core-java to 8.0.3

@ahmed-ali-55 ahmed-ali-55 added the patch Triggers a patch release label Nov 24, 2023
@geoandri geoandri removed the patch Triggers a patch release label Nov 27, 2023
@geoandri
Copy link
Contributor

geoandri commented Nov 27, 2023

@ahmed-ali-55 , I removed the patch label because we create a different PR for this, that also handles the version (see #65). It also seems to me like a minor version instead of a patch based on this.

Can you also add a more descriptive functionality-wise title (e.g. Generate CycloneDX v1.5 Sbom files or something similar) instead of the technical description since this is going to be part of the release notes?

@geoandri geoandri added the enhancement New feature or request label Nov 27, 2023
@ahmed-ali-55 ahmed-ali-55 changed the title [CID-2087] Removing CycloneDx=schema.version from ort report params and upgrading cyclonedx-core-java to 8.0.3 [CID-2087] Generate CycloneDX v1.5 Sbom files Nov 27, 2023
@ahmed-ali-55 ahmed-ali-55 merged commit 16ec919 into main Nov 27, 2023
2 checks passed
@ahmed-ali-55 ahmed-ali-55 deleted the feature/CID-2087/cyclonesx-version-1-5 branch November 27, 2023 13:48
This was referenced Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants