Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all peers when running as a bootstrap node #3631

Merged
merged 9 commits into from
Aug 29, 2022
Merged

Add all peers when running as a bootstrap node #3631

merged 9 commits into from
Aug 29, 2022

Conversation

shyba
Copy link
Member

@shyba shyba commented Jul 11, 2022

closes #3626

@coveralls
Copy link

coveralls commented Jul 11, 2022

Coverage Status

Coverage increased (+0.07%) to 57.817% when pulling e3ee389 on bootstrap_node into 01cd95f on master.

@shyba shyba marked this pull request as ready for review July 14, 2022 19:13
@shyba shyba requested a review from jackrobison July 14, 2022 19:13
@lbry-bot lbry-bot assigned jackrobison and unassigned shyba Jul 14, 2022
@shyba shyba force-pushed the bootstrap_node branch 2 times, most recently from c989828 to 631c464 Compare August 2, 2022 14:27
lbry/dht/protocol/routing_table.py Outdated Show resolved Hide resolved
@lbry-bot lbry-bot assigned shyba and unassigned jackrobison Aug 3, 2022
@@ -11,6 +11,34 @@
from lbry.extras.daemon.storage import SQLiteStorage


class TestBootstrapNode(AsyncioTestCase):
TIMEOUT = 10.0 # do not increase. Hitting a timeout is a real failure
async def test_it_adds_all(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this have a more descriptive name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

peers in the routing table. During bootstrap the shortlist is set to be the seed nodes.
"""
if len(key) != constants.HASH_LENGTH:
raise ValueError("invalid key length: %i" % len(key))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this dropped intentionally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shyba shyba requested a review from jackrobison August 19, 2022 15:08
@lbry-bot lbry-bot assigned jackrobison and unassigned shyba Aug 19, 2022
@lbry-bot lbry-bot assigned shyba and unassigned jackrobison Aug 26, 2022
@shyba shyba merged commit a334a93 into master Aug 29, 2022
@shyba shyba deleted the bootstrap_node branch August 29, 2022 14:07
@eukreign eukreign added type: improvement Existing (or partially existing) functionality needs to be changed area: blob exchange labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: blob exchange type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap node issue (stub)
4 participants