Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only announce sd blobs, stop announcing head blobs #3565

Merged
merged 4 commits into from
Feb 21, 2022

Conversation

shyba
Copy link
Member

@shyba shyba commented Feb 9, 2022

backwards-incompatible: For desktop / lbry-sdk users: this release includes a migration that increasing the database version. This usually means you can't downgrade without a backup of lbrynet.sqlite.

This should make 1 announcement per stream instead of 2.

  • stop announcing the head blob
  • stop searching for it
  • migration script to set all head blobs to should_announce=false

part of #3527 but probably doesn't close it (faster hash announcer and tracker to go)

@shyba shyba added type: improvement Existing (or partially existing) functionality needs to be changed area: DHT area: blobs/files labels Feb 9, 2022
@coveralls
Copy link

coveralls commented Feb 9, 2022

Coverage Status

Coverage remained the same at 69.7% when pulling 3ee3e7f on stop_announcing_head_blob into 43ac333 on master.

@shyba shyba marked this pull request as ready for review February 9, 2022 03:08
@lbry-bot lbry-bot assigned jackrobison and unassigned shyba Feb 9, 2022
@@ -37,6 +37,8 @@ def migrate_db(conf, start, end):
from .migrate13to14 import do_migration
elif current == 14:
from .migrate14to15 import do_migration
elif current == 15:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be documented as a breaking change, users will only be able to downgrade by manually editing the version file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@lbry-bot lbry-bot assigned shyba and unassigned shyba Feb 16, 2022
@shyba shyba merged commit dd5b9ca into master Feb 21, 2022
@shyba shyba deleted the stop_announcing_head_blob branch February 21, 2022 01:33
@jackrobison jackrobison changed the title DHT: stop announcing the head blob Only announce sd blobs, stop announcing head blobs Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: blobs/files area: DHT type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants