Skip to content

Commit

Permalink
[SQLite] encoding & decoding NaiveTime with correct format (#1459)
Browse files Browse the repository at this point in the history
* Fix SQLite encoding format

* Update SQLite decoding format

* Update sqlx-core/src/sqlite/types/chrono.rs

* fixup: add `#[rustfmt::skip]`

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Co-authored-by: Austin Bonander <austin@launchbadge.com>
  • Loading branch information
3 people committed Oct 1, 2021
1 parent 51e45ce commit 8561891
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions sqlx-core/src/sqlite/types/chrono.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl Encode<'_, Sqlite> for NaiveDate {

impl Encode<'_, Sqlite> for NaiveTime {
fn encode_by_ref(&self, buf: &mut Vec<SqliteArgumentValue<'_>>) -> IsNull {
Encode::<Sqlite>::encode(self.format("%T%.f%").to_string(), buf)
Encode::<Sqlite>::encode(self.format("%T%.f").to_string(), buf)
}
}

Expand Down Expand Up @@ -179,9 +179,11 @@ impl<'r> Decode<'r, Sqlite> for NaiveTime {

// Loop over common time patterns, inspired by Diesel
// https://github.com/diesel-rs/diesel/blob/93ab183bcb06c69c0aee4a7557b6798fd52dd0d8/diesel/src/sqlite/types/date_and_time/chrono.rs#L29-L47
#[rustfmt::skip] // don't like how rustfmt mangles the comments
let sqlite_time_formats = &[
// Most likely format
"%T.f", // Other formats in order of appearance in docs
"%T.f", "%T%.f",
// Other formats in order of appearance in docs
"%R", "%RZ", "%T%.fZ", "%R%:z", "%T%.f%:z",
];

Expand Down

0 comments on commit 8561891

Please sign in to comment.