Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to arkworks grumpkin and use curve config #82

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

lonerapier
Copy link
Contributor

Description

include changes to move grumpkin to arkworks curve and using SWCurveConfig trait.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Refactor (non-breaking change that updates existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Comments have been added/updated

Please delete options that are not relevant.

@laudiacay
Copy link
Owner

going to make some tiny changes

Copy link
Owner

@laudiacay laudiacay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, i just completed some tiny nits to get the tests running (in the future please check that the tests run!)

@laudiacay laudiacay merged commit b250574 into laudiacay:main Oct 11, 2023
0 of 9 checks passed
@laudiacay
Copy link
Owner

also please let me know if you're waiting on my review! sorry I let this sit so long.

@lonerapier
Copy link
Contributor Author

thanks. super sorry for not checking tests.
will keep in mind for the future.

@lonerapier lonerapier deleted the feat/curve-config branch October 11, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants