Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of binary for aarch64-apple-darwin(M1 mac) to GitHub release pages #591

Merged

Conversation

yoshida-ryuhei
Copy link
Contributor

Add support of binary for aarch64-apple-darwin, which is related to #589.

What is not going well is

  • I am not sure the way to test the aarch64-apple-darwin binary.
    I wrote a job to check, but the cargo looks not adapt to test a cross compiler.
    I can delete the job.

I would appreciate it if you could check this pull request and comment to my concern.

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #591 (5d34742) into master (14c981d) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   78.50%   78.43%   -0.08%     
==========================================
  Files         123      124       +1     
  Lines        8197     8378     +181     
==========================================
+ Hits         6435     6571     +136     
- Misses       1762     1807      +45     
Impacted Files Coverage Δ
src/syntax/latex/lexer.rs 84.31% <0.00%> (-15.69%) ⬇️
src/features/completion/include.rs 47.82% <0.00%> (-3.43%) ⬇️
src/syntax/latex/cst.rs 54.89% <0.00%> (-0.96%) ⬇️
src/syntax/latex/kind.rs 100.00% <0.00%> (ø)
src/syntax/latex/analysis/mod.rs 100.00% <0.00%> (ø)
src/syntax/latex/analysis/types.rs 100.00% <0.00%> (ø)
src/syntax/latex/analysis/graphics_path.rs 28.57% <0.00%> (ø)
src/syntax/latex/parser.rs 83.28% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c981d...5d34742. Read the comment docs.

@pfoerster
Copy link
Member

Thanks for the PR.

I am not sure the way to test the aarch64-apple-darwin binary. I wrote a job to check, but the cargo looks not adapt to test a cross compiler.

Yeah, I do not think there is an easy way to run the unit tests for the aarch64-apple-darwin binary. Running the tests means executing a file that contains the compiled tests (aarch64 in this case) on the current host (x86_64). This won't work without some virtualization technique. For the moment, I think it is better to skip the tests on aarch64 for now.

I am still a bit surprised that this appears to be quite easy on macOS. To cross compile for FreeBSD, you have to install/compile a C/C++ cross compiler first and then compile the Rust code (which takes a lot of time). It looks like this step is not required on macOS and/or cargo does some magic ;)

@yoshida-ryuhei
Copy link
Contributor Author

Thank you for the comment. It gave me the confidence not to test.

I have deleted the test for aarch64-apple-darwin, which is difficult to do.

Now, this pull request is enough to merge for me.
I would appreciate it if you could consider merging this pull request.

@yoshida-ryuhei yoshida-ryuhei changed the title [WIP] Add support of binary for aarch64-apple-darwin(M1 mac) to GitHub release pages Add support of binary for aarch64-apple-darwin(M1 mac) to GitHub release pages Apr 3, 2022
Copy link
Member

@pfoerster pfoerster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pfoerster pfoerster merged commit d29f1e3 into latex-lsp:master Apr 3, 2022
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 29, 2022
## [4.0.0] - 25.05.2022

### Added

- Add `--version` command line flag
- Provide pre-built binaries for `aarch64-apple-darwin` architecture ([#591](latex-lsp/texlab#591))
- Autocomplete files based on `\graphicspath` ([#590](latex-lsp/texlab#590))
- Release `texlab` on `crates.io` ([#399](latex-lsp/texlab#399))

### Changed

- _BREAKING_: Use client-side file watching instead of server-side notifications (`workspace/didChangeWatchedFiles`)
- _BREAKING_: Bump minimum supported Rust version to 1.58.1
- _BREAKING_: Do not use `citeproc-rs` to render citations. Instead, use a custom approach that tries to resemble the `BibLaTeX` output ([#629](latex-lsp/texlab#629))

### Fixed

- Parse `\subinputfrom` command correctly ([#610](latex-lsp/texlab#610))
- Parse verbatim environments correctly ([#490](latex-lsp/texlab#490))
- Stop capturing stdout when build exits ([#588](latex-lsp/texlab#588))
- Fix parsing of key-value pairs ([#573](latex-lsp/texlab#573))
- Normalize `texlab.rootDirectory` when resolving includes ([#571](latex-lsp/texlab#571))
- Allow optional arguments in environment definitions ([#570](latex-lsp/texlab#570))
- Allow `=` in include paths ([#568](latex-lsp/texlab#568))
@yoshida-ryuhei yoshida-ryuhei deleted the feature/aarch64-apple-darwin branch March 11, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants