-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of binary for aarch64-apple-darwin(M1 mac) to GitHub release pages #591
Add support of binary for aarch64-apple-darwin(M1 mac) to GitHub release pages #591
Conversation
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
- Coverage 78.50% 78.43% -0.08%
==========================================
Files 123 124 +1
Lines 8197 8378 +181
==========================================
+ Hits 6435 6571 +136
- Misses 1762 1807 +45
Continue to review full report at Codecov.
|
Thanks for the PR.
Yeah, I do not think there is an easy way to run the unit tests for the I am still a bit surprised that this appears to be quite easy on macOS. To cross compile for FreeBSD, you have to install/compile a C/C++ cross compiler first and then compile the Rust code (which takes a lot of time). It looks like this step is not required on macOS and/or |
Thank you for the comment. It gave me the confidence not to test. I have deleted the test for Now, this pull request is enough to merge for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
## [4.0.0] - 25.05.2022 ### Added - Add `--version` command line flag - Provide pre-built binaries for `aarch64-apple-darwin` architecture ([#591](latex-lsp/texlab#591)) - Autocomplete files based on `\graphicspath` ([#590](latex-lsp/texlab#590)) - Release `texlab` on `crates.io` ([#399](latex-lsp/texlab#399)) ### Changed - _BREAKING_: Use client-side file watching instead of server-side notifications (`workspace/didChangeWatchedFiles`) - _BREAKING_: Bump minimum supported Rust version to 1.58.1 - _BREAKING_: Do not use `citeproc-rs` to render citations. Instead, use a custom approach that tries to resemble the `BibLaTeX` output ([#629](latex-lsp/texlab#629)) ### Fixed - Parse `\subinputfrom` command correctly ([#610](latex-lsp/texlab#610)) - Parse verbatim environments correctly ([#490](latex-lsp/texlab#490)) - Stop capturing stdout when build exits ([#588](latex-lsp/texlab#588)) - Fix parsing of key-value pairs ([#573](latex-lsp/texlab#573)) - Normalize `texlab.rootDirectory` when resolving includes ([#571](latex-lsp/texlab#571)) - Allow optional arguments in environment definitions ([#570](latex-lsp/texlab#570)) - Allow `=` in include paths ([#568](latex-lsp/texlab#568))
Add support of binary for
aarch64-apple-darwin
, which is related to #589.What is not going well is
I wrote a job to check, but the cargo looks not adapt to test a cross compiler.
I can delete the job.
I would appreciate it if you could check this pull request and comment to my concern.