Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notifications on registration failure #51

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Conversation

lasuillard
Copy link
Owner

Display a toast notification if the OAuth application registration is unsuccessful.

Additionally, implement the following features:

  • Enable users to manually input an access token, allowing the use of a test token and eliminating the necessity for OAuth app registration.
  • Eliminate the unattractive focus outline around the menu icon when it is clicked.

Resolves #28 and fixes #38.

@lasuillard lasuillard added the enhancement New feature or request label Jul 19, 2024
@lasuillard lasuillard self-assigned this Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 72.64151% with 29 lines in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (7fe03ef) to head (74cfcae).
Report is 1 commits behind head on main.

Files Patch % Lines
src/lib/messages.ts 68.75% 14 Missing and 1 partial ⚠️
src/pages/options/Page.svelte 0.00% 13 Missing ⚠️
src/components/Message.svelte 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   68.57%   69.20%   +0.63%     
==========================================
  Files          19       21       +2     
  Lines         910     1010     +100     
  Branches       58       60       +2     
==========================================
+ Hits          624      699      +75     
- Misses        233      256      +23     
- Partials       53       55       +2     
Flag Coverage Δ
unit 69.20% <72.64%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lasuillard lasuillard merged commit 20d6e5b into main Jul 19, 2024
8 checks passed
@lasuillard lasuillard deleted the 28-registration-failure branch July 19, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus on icon Show error on registration failure
1 participant