Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix misleading memory limit config #908

Merged
merged 1 commit into from
Oct 12, 2020
Merged

[5.x] Fix misleading memory limit config #908

merged 1 commit into from
Oct 12, 2020

Conversation

paras-malhotra
Copy link
Contributor

@paras-malhotra paras-malhotra commented Oct 9, 2020

The memory_limit Horizon configuration is misleading. It reads that it's the max memory for the queue workers, when instead, it is the memory limit for the master supervisor (default 64 MB). The memory limit for the workers percolates down from the supervisor memory limit (default 128 MB).

This PR fixes the wording and also makes it clear that the supervisor memory option is the one for the queue workers. This is a non-breaking change, as the config defaults are the same (64 MB for master supervisor and 128 MB for supervisors + queue workers).

Edit: On digging further, I realised this issue has been lingering from quite some time now: #712

@taylorotwell taylorotwell merged commit 948cfea into laravel:5.x Oct 12, 2020
@paras-malhotra paras-malhotra deleted the fix_memory_config branch October 12, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants