Reset the retryUntil value #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyago
approved these changes
Dec 30, 2019
| protected function prepareNewTimeout($payload) | ||
| { | ||
| return $payload['timeoutAt'] | ||
| ? Chronos::now()->addSeconds(ceil($payload['timeoutAt'] - $payload['pushedAt']))->getTimestamp() |
There was a problem hiding this comment.
@themsaid that is a nice solution, very good, thank you !
We had solved this internally by just overriding the RetryFailedJob class and setting timeoutAt to null, but this looks like a better approach indeed. But that's exactly why I haven't pushed a pull request; I didn't feel like I could make the best code decisions while contributing to Horizon just yet.
|
I know I'm not supposed to review stuff, but I did haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.