[3.0] Allow custom dashboard failed jobs metric period #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add config('horizon.trim.recent_failed')
to control the dashboard "Failed Jobs"
metric period. By default, it will be
the past 7 days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: #637
Add
config('horizon.trim.recent_failed')to control the dashboard "Failed Jobs" metric period. A typical use case is for Horizon to track the exceptions across the past 7 days but the dashboard only shows the failure count from the past 24 hours.By default, it will fallback to
config('horizon.failed')(past 7 days) since Laravel Horizon 3.0 installs will be missing config/horizon.php key'recent_failed'. This makes the 3.0 branch continue to behave as normal to users unaware this can be changed with a new config key.The 4.0 branch can probably remove this fallback for a hardcoded 10080 minutes / 7 days.