Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add cancelled status to batch overview #1255

Merged
merged 3 commits into from
Mar 6, 2023
Merged

[5.x] Add cancelled status to batch overview #1255

merged 3 commits into from
Mar 6, 2023

Conversation

markvaneijk
Copy link
Contributor

@markvaneijk markvaneijk commented Mar 6, 2023

Currently it's not visible if a batch is cancelled and instead it still shows Pending even when the batch is cancelled and not running anymore.

I found this quite confusing when cancelling batches for a specific use case where only one batch may run at once and the previous needs to be cancelled when there is already one pending.

So this adds the functionality to show the status of cancelled batches:

CleanShot 2023-03-06 at 16 28 55@2x

@markvaneijk
Copy link
Contributor Author

markvaneijk commented Mar 6, 2023

Choice for badge could also be badge-warning.

@markvaneijk markvaneijk changed the title Add cancelled status to batch overview [5.x] Add cancelled status to batch overview Mar 6, 2023
@taylorotwell taylorotwell merged commit 19a9999 into laravel:5.x Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants