Move contents of #horizon to separate component #1022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the contents of the
#horizon
div to a separate component. This fixes #1018 and #576.The html in the root Vue element cause Vue to use
new Function
, which is not allowed when using a Content Security Policy that does not include'unsafe-eval'
, which causes the Horizon Dashboard to not work at all if such a CSP is present. Moving the content into a separate vue component fixes this. (ref. laravel-mix/laravel-mix#1052 (comment))As far as I can tell nothing breaks due to this PR.
I was not sure if I should have included the compiled js in this PR, can remove if wanted.