Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HuggingFaceTextGenInference bug fix: Multiple values for keyword argument #8044

Merged
merged 6 commits into from
Jul 21, 2023
Merged

HuggingFaceTextGenInference bug fix: Multiple values for keyword argument #8044

merged 6 commits into from
Jul 21, 2023

Conversation

WianStipp
Copy link
Contributor

Fixed the bug causing: TypeError: generate() got multiple values for keyword argument 'stop_sequences'

res = await self.async_client.generate(
                prompt,
                **self._default_params,
                stop_sequences=stop,
                **kwargs,
            )

The above throws an error because stop_sequences is in also in the self._default_params.

@baskaryan review please?

@vercel
Copy link

vercel bot commented Jul 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 1:57am

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jul 21, 2023
@vercel vercel bot temporarily deployed to Preview July 21, 2023 00:59 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2023 01:07 Inactive
@baskaryan baskaryan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 21, 2023
@vercel vercel bot temporarily deployed to Preview July 21, 2023 01:21 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2023 01:45 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2023 01:57 Inactive
@baskaryan baskaryan merged commit ebc5ff2 into langchain-ai:master Jul 21, 2023
13 checks passed
@baskaryan
Copy link
Collaborator

thanks for flagging and fixing @WianStipp!

@htang2012
Copy link

Thanks for fixing this issue @WianStipp, I was about file a ticket :)

@adarshxs adarshxs mentioned this pull request Jul 21, 2023
Closed
14 tasks
@dosubot dosubot bot mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WianStipp @baskaryan @htang2012