Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedding and vectorstore provider info as tags #8027

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

hinthornw
Copy link
Collaborator

Example: https://smith.langchain.com/public/bcd3714d-abba-4790-81c8-9b5718535867/r

The vectorstore implementations aren't super standardized yet, so just adding an optional embeddings property to pass in.

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 20, 2023 8:50pm

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:improvement Medium size change to existing code to handle new use-cases labels Jul 20, 2023
@@ -346,6 +347,7 @@ def on_retriever_start(
start_time=start_time,
execution_order=execution_order,
child_execution_order=execution_order,
tags=tags,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix

@hwchase17 hwchase17 merged commit c38965f into master Jul 21, 2023
14 checks passed
@hwchase17 hwchase17 deleted the wfh/add_embedding_info branch July 21, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants