Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align chroma vectorstore get with chromadb to enable where filtering #6686

Merged
merged 4 commits into from
Jun 26, 2023
Merged

align chroma vectorstore get with chromadb to enable where filtering #6686

merged 4 commits into from
Jun 26, 2023

Conversation

ChrisPappalardo
Copy link
Contributor

allows for where filtering on collection via get

  • Description: aligns langchain chroma vectorstore get with underlying chromadb collection get allowing for where filtering, etc.
  • Issue: NA
  • Dependencies: none
  • Tag maintainer: @rlancemartin, @eyurtsev
  • Twitter handle: @pappanaka

@ChrisPappalardo
align chroma vectorstore get method interface with chromadb
89f0483 
allows for where filtering on collection via get
@vercel
Copy link

vercel bot commented Jun 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jun 26, 2023 4:41pm

@ChrisPappalardo ChrisPappalardo changed the title align chroma vectorstore get method interface with chromadb align chroma vectorstore get method with chromadb to enable where filtering Jun 24, 2023
@ChrisPappalardo ChrisPappalardo changed the title align chroma vectorstore get method with chromadb to enable where filtering align chroma vectorstore get with chromadb to enable where filtering Jun 24, 2023
hwchase17
hwchase17 approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 25, 2023
@ChrisPappalardo
Copy link
Contributor Author

thanks!

You bet. I just fixed the chromadb typing imports that were causing linting errors.

@rlancemartin rlancemartin self-assigned this Jun 26, 2023
rlancemartin
rlancemartin reviewed Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@rlancemartin rlancemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe you should add an example of where filter to the notebook?

@rlancemartin
Copy link
Collaborator

Also, please run make format to resolve Lint error. LMK if problems, and I can help w/ that.

@ChrisPappalardo
Copy link
Contributor Author

@rlancemartin Done. Let me know if you want me to squash these commits.

@ChrisPappalardo
Copy link
Contributor Author

Both make format and poetry run ruff . now pass without issues.

@rlancemartin rlancemartin merged commit 70f7c2b into langchain-ai:master Jun 26, 2023
13 checks passed
@ChrisPappalardo ChrisPappalardo deleted the patch-1 branch June 29, 2023 17:08
@McDonnellJoseph McDonnellJoseph mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlancemartin rlancemartin rlancemartin left review comments

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees

@rlancemartin rlancemartin

Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisPappalardo @rlancemartin @hwchase17