Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bedrock chat model load. #26643

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Fixed bedrock chat model load. #26643

merged 3 commits into from
Sep 19, 2024

Conversation

3coins
Copy link
Contributor

@3coins 3coins commented Sep 19, 2024

Fixes load for ChatBedrock, in-turn fixes unit test errors for standard-tests in langchain-aws, when working with v0.2 branch.

FAILED tests/unit_tests/test_standard.py::TestBedrockStandard::test_serdes - ValueError: Trying to deserialize something that cannot be deserialized in current version of langchain-core: ('langchain', 'cha...
FAILED tests/unit_tests/test_standard.py::TestBedrockAsConverseStandard::test_serdes - ValueError: Trying to deserialize something that cannot be deserialized in current version of langchain-core: ('langchain', 'cha...

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 5:45pm

@3coins 3coins marked this pull request as ready for review September 19, 2024 17:57
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: core Related to langchain-core 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 19, 2024
efriis
efriis approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @baskaryan

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 19, 2024
efriis
efriis reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should we add this to 0.3 as well?

@3coins
Copy link
Contributor Author

3coins commented Sep 19, 2024 •
edited
Loading

also should we add this to 0.3 as well?

Yes, I can submit another PR. Submitted #26679 for master.

@3coins 3coins mentioned this pull request Sep 19, 2024
Merged
baskaryan added a commit that referenced this pull request Sep 19, 2024
@3coins @baskaryan
core[patch]: Fix load of ChatBedrock (#26679)
f087ab4 
Complementary PR to master for #26643.

Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
@baskaryan baskaryan merged commit c5eca37 into langchain-ai:v0.2 Sep 19, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

@baskaryan baskaryan baskaryan approved these changes

Assignees

@baskaryan baskaryan

Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3coins @efriis @baskaryan