Rename accessibility_options_used -> accessibility_options in Trips payload #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…descriptive description
philipjrose
reviewed
Sep 4, 2020
avatarneil
deleted the
feature/neil/extend-accessibility-options-in-trips-payload
branch
brianngca
reviewed
Sep 9, 2020
| @@ -378,7 +378,7 @@ The reservation method enum describes the different ways in which a passenger ca | |||
| | distance | Float | Conditionally Required | Total distance of the trip in meters (required if trip was completed) | | |||
| | cancellation_reason | string | Conditionally Required | The reason why a *driver* cancelled a reservation. (required if a driver cancelled a trip, and a `driver_cancellation` event_type was part of the trip) | | |||
| | fare | [Fare](#fare) | Conditionally Required | Fare for the trip (required if trip was completed) | | |||
| | accessibility_options | Enum[] | Optional | The **union** of any accessibility options requested, and used. E.g. if the passenger requests a vehicle with `wheelchair_boarding`, but doesn’t utilize the features during the trip, the trip payload will include `accessibility_options: ['wheelchair_boarding']`. See [accessibility-options][accessibility-options] | | |||
| | accessibility_options | Enum[] | Optional | The **union** of any accessibility options requested, and used. E.g. if the passenger requests a vehicle with `wheelchair_accessible`, but doesn’t utilize the features during the trip, the trip payload will include `accessibility_options: ['wheelchair_accessible']`. See [accessibility-options][accessibility-options] | | |||
There was a problem hiding this comment.
What is supposed to be in the payload if the accessibility option is requested AND is used?
The link "accessibility-options" redirects to the agency spec, but that doesn't contain any mention of accessibility-options
There was a problem hiding this comment.
The link ought to redirect to general-information.md, hm. In the case that it's requested and used, it's inclusive, so it should just be the same as if it was only requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add more descriptive description :)