Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #4

Closed
kynan opened this issue Jan 24, 2016 · 9 comments
Closed

Add tests #4

kynan opened this issue Jan 24, 2016 · 9 comments

Comments

@kynan
Copy link
Owner

kynan commented Jan 24, 2016

Some simple unit tests to make sure we don't accidentally break stuff.

@mforbes
Copy link
Contributor

mforbes commented Jan 25, 2016

cram might be a good tool for this. (It is based on the tool used to test mercurial.)

@kynan
Copy link
Owner Author

kynan commented Jan 26, 2016

OK, will take a look. I'm a big fan of pytest.

kynan added a commit that referenced this issue Jan 26, 2016
@kynan
Copy link
Owner Author

kynan commented Jan 27, 2016

Have started with a trivial Travis config that only runs flake8.

@mforbes
Copy link
Contributor

mforbes commented Jan 27, 2016

I added a small modules pytest_cram.py that allows you to run cram from pytest as well as a small (dummy) test that runs mercurial. I am not finished with my hooks yet, but you should be able to simply modify this to run git tests.

@kynan
Copy link
Owner Author

kynan commented Jan 31, 2016

@mforbes Great, do you want to pr this?

@mforbes
Copy link
Contributor

mforbes commented Jan 31, 2016

Sure. Could you please remind me what I have to do to rebase my changes on yours or shall I just submit the PR as is? (I still find git somewhat confusing and am not sure of the magic incantation needed to pull in your changes and then rebase mine...)

@kynan
Copy link
Owner Author

kynan commented Jan 31, 2016

Ah, yes, sure! Assuming my repo is upstream you do

git fetch upstream
git rebase upstream/master
git push --force

@mforbes
Copy link
Contributor

mforbes commented Feb 1, 2016

Done. (thanks)

@kynan kynan added this to the 0.2.3 milestone Feb 15, 2016
@kynan
Copy link
Owner Author

kynan commented Feb 15, 2016

We have some simple tests now (to be extended!), hence closing.

@kynan kynan closed this as completed Feb 15, 2016
@kynan kynan self-assigned this Feb 15, 2016
ooiM added a commit to ooiM/nbstripout that referenced this issue Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants