Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have a --is_installed check? #29

Closed
michaelaye opened this issue Apr 20, 2016 · 11 comments
Closed

Can we have a --is_installed check? #29

michaelaye opened this issue Apr 20, 2016 · 11 comments

Comments

@michaelaye
Copy link
Contributor

I'm loosing track where I have nbstripout in use and where not.
Could we have a little check run like:
nbstripout --is_installed
that simple returns: "nbstripout is installed in this repo" or "nbstripout is not installed in this repo" respectively?
Would be great, thanks!

@kynan
Copy link
Owner

kynan commented Apr 20, 2016

Yes, good idea, shouldn't be hard to implement, will have a look.

@kynan kynan self-assigned this Apr 20, 2016
@kynan kynan added this to the 0.2.7 milestone Apr 20, 2016
@kynan
Copy link
Owner

kynan commented Apr 23, 2016

@michaelaye I'd prefer to follow the GNU convention i.e. use --is-installed.

Rather than printing a message I'd rather use the exit / status code i.e. 0 if installed, 1 if not installed, what do you think?

Maybe we could have another switch e.g. --status to print a summary like you suggest, maybe also including details on the filter.

kynan added a commit that referenced this issue Apr 23, 2016
Checks if nbstripout is installed in the current repository.
kynan added a commit that referenced this issue Apr 23, 2016
@kynan
Copy link
Owner

kynan commented Apr 25, 2016

@michaelaye I have implemented the status code (without output). Any thoughts?

@michaelaye
Copy link
Contributor Author

Thanks, I'd still like a version with a text output though. The whole idea of this is for non-hackers to be able to do this, and those most likely don't know anything about GNU exit codes.

@themiurgo
Copy link

themiurgo commented Jul 29, 2016

This functionality is already documented in the README, but it's not yet present. Maybe it's worth removing from the current documentation until it's implemented and merged?

@kynan
Copy link
Owner

kynan commented Jul 29, 2016

@themiurgo The feature is in master but not yet released. I'll implement the status functionality @michaelaye was asking for and cut a new release.

@kynan kynan closed this as completed in 0b4a57e Jul 29, 2016
kynan added a commit that referenced this issue Jul 29, 2016
@kynan
Copy link
Owner

kynan commented Jul 29, 2016

@themiurgo 0.2.7 is released!

@kynan
Copy link
Owner

kynan commented Jul 29, 2016

@michaelaye I've added a --status command, please let me know if that is satisfactory and reopen this issue if not!

@michaelaye
Copy link
Contributor Author

Okay, thanks. major issue i have recently is the performance though. everytime i go into a repo with lots of notebooks, it takes 5 seconds before i get my prompt back, which can be annoying...
I'm wondering if the official PreProcessor of the notebook tools is faster than your manual filtering?

@kynan
Copy link
Owner

kynan commented Aug 10, 2016

@michaelaye Yes, speed is an issue indeed. Want to create an issue for it?

@michaelaye
Copy link
Contributor Author

#33 ;)

ooiM added a commit to ooiM/nbstripout that referenced this issue Jun 2, 2020
Checks if nbstripout is installed in the current repository.
ooiM added a commit to ooiM/nbstripout that referenced this issue Jun 2, 2020
ooiM added a commit to ooiM/nbstripout that referenced this issue Jun 2, 2020
ooiM added a commit to ooiM/nbstripout that referenced this issue Jun 2, 2020
Print status of nbstripout installation in current repository and
configuration summary if installed.
ooiM added a commit to ooiM/nbstripout that referenced this issue Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants