Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting an alternative default database with postgres #640

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

georgepstaylor
Copy link

Digital Ocean managed postgres database servers use 'defaultdb' instead of postgres.
This should be allowed to be changed, rather than hard coded

@kurtmckee
Copy link
Collaborator

@georgepstaylor It looks like your system may have run black against the file when you made changes to it (black is not yet used for code linting, but may be introduced in the future). For now, this has made the functional changes significantly more difficult to understand, because they are obscured by a much bigger diff than is needed.

Would you be willing to isolate the functional changes and resubmit? If you're not comfortable rewriting git history and force-pushing to GitHub, you might need to create a new branch.

@georgepstaylor
Copy link
Author

@kurtmckee, you are correct - apologies didn't catch that! I will resubmit

@georgepstaylor
Copy link
Author

@kurtmckee, all sorted - diff looks much easier to read!

@georgepstaylor georgepstaylor changed the title Allow selecting default database when using create_database() Allow selecting an alternative default database with postgres Nov 15, 2022
@georgepstaylor
Copy link
Author

Hi, is this repo still actively maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants