Fix timeouts on plugin action returing the request #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1-dev #1297 +/- ##
==========================================
+ Coverage 93.84% 93.84% +<.01%
==========================================
Files 98 98
Lines 6852 6857 +5
==========================================
+ Hits 6430 6435 +5
Misses 422 422
Continue to review full report at Codecov.
|
Aschen
suggested changes
May 9, 2019
scottinet
suggested changes
May 10, 2019
| if (!this.isNativeController(modifiedRequest) && !modifiedRequest.response.raw) { | ||
| // check if the plugin response can be serialized | ||
| try { | ||
| JSON.stringify(modifiedRequest.response.toJSON()); |
There was a problem hiding this comment.
This check should be performed directly on responseData to prevent the unnecessary overhead of RequestResponse.toJSON.
Aschen
approved these changes
May 13, 2019
scottinet
approved these changes
May 14, 2019
Yoann-Abbes
approved these changes
May 14, 2019
|
The fact a routs plugin cannot send non-serialisable response anymore shoudnt be documented ? |
|
@Yoann-Abbes > it is documented, and plugins can send non-serializable responses by setting the |
Merged
Aschen
added a commit
that referenced
this pull request
Jun 14, 2019
Release 1.8.0
Bug fixes
[ #1311 ] Fix promise leaks (scottinet)
[ #1298 ] Fix disabled protocol initialization (Aschen)
[ #1297 ] Fix timeouts on plugin action returing the request (benoitvidis)
[ #1288 ] Fix an error when trying a non-partial bulk update (scottinet)
[ #1286 ] Allows bulk inserts on aliases (benoitvidis)
[ #1282 ] Scan keys on redis cluster (benoitvidis)
[ #1279 ] Users must be authenticated to use auth:logout (scottinet)
New features
[ #1315 ] Add the new Vault module to handle encrypted application secrets (Aschen)
[ #1302 ] Add write and mWrite (Aschen)
[ #1305 ] Add pipes & hooks wildcard event (thomasarbona)
Enhancements
[ #1318 ] Add a maximum ttl to auth:login (benoitvidis)
[ #1301 ] Upgrade the WebSocket libraries (scottinet)
[ #1308 ] Events triggering refactor (scottinet)
[ #1300 ] Collection specifications methods cloisoned to a collection (thomasarbona)
[ #1295 ] Improve validation error messages (benoitvidis)
[ #1292 ] Throw an error when the realtime controller is invoked by plugin developers (benoitvidis)
[ #1257 ] Add ability to define mapping policy for new fields (Aschen)
[ #1291 ] Fix --help on subcommands (Yoann-Abbes)
[ #1289 ] Handle ping/pong packets (scottinet)
[ #1273 ] Fix incomplete access logs (scottinet)
Others
[ #1317 ] Add ps dependency to plugin-dev Docker image for pm2 (benoitvidis)
[ #1312 ] Check that .kuzzlerc.sample is well-formed (scottinet)
[ #1299 ] Add Kuzzle Nightly & Redis 3 and 4 test (alexandrebouthinon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes the case where Kuzzle would timeout without error when/if a plugin controller action returns a non-serializable response.
This is notably the case if a controller action returns the origin request.