Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added strategy support for validating status code #35

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

philprime
Copy link
Collaborator

No description provided.

@philprime philprime self-assigned this Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Warnings
⚠️ Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review.

SwiftLint found issues

Severity File Reason
Warning HTTPStatusCodeTests.swift:1 SwiftLint rule 'type_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Generated by 🚫 Danger Swift against eafa1d8

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #35 (eafa1d8) into main (bd71eea) will increase coverage by 0.74%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   56.55%   57.30%   +0.74%     
==========================================
  Files          53       54       +1     
  Lines        1517     1541      +24     
==========================================
+ Hits          858      883      +25     
+ Misses        659      658       -1     
Flag Coverage Δ
unittests 57.30% <75.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Sources/Postie/HTTPAPIClient.swift 50.78% <ø> (ø)
...es/Postie/Utils/LoggingURLEncodedFormDecoder.swift 28.57% <0.00%> (-21.43%) ⬇️
Sources/PostieMock/URLSessionCallbackStub.swift 44.44% <ø> (ø)
...Postie/Encoder/RequestKeyedEncodingContainer.swift 58.18% <33.33%> (ø)
...ostie/Decoder/ResponseKeyedDecodingContainer.swift 45.45% <60.00%> (+3.51%) ⬆️
...s/ResponseErrorBody/ResponseErrorBodyWrapper.swift 82.35% <82.35%> (ø)
...e/Responses/ResponseBody/ResponseBodyWrapper.swift 86.36% <100.00%> (+10.17%) ⬆️
...s/Postie/Strategies/Body/DefaultBodyStrategy.swift 100.00% <100.00%> (ø)
...tie/Strategies/Body/DefaultErrorBodyStrategy.swift 100.00% <100.00%> (ø)
...stie/Strategies/Body/OptionalContentStrategy.swift 100.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 13c1044 into main Sep 19, 2023
6 checks passed
@kodiakhq kodiakhq bot deleted the feature/body-validation-strategies branch September 19, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants