Ensure virt-export route has redirect policy

[awels]

What this PR does

Before this PR:
The virt-export route did not have an EdgeTerminationPolicy set.

After this PR:
The virt-export route has an EdgeTerminationPolicy of redirect to ensure that insecure requests are automatically redirected to the secure route.

Fixes https://issues.redhat.com/browse/CNV-43248

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note

Virt export route has an edge termination of redirect

[awels]

/retest

[fossedihelm]

Thank you @awels!
General question: Should we redirect or block insecure connections?
Regarding the code: only two little things regarding the pkg.

I know that this is outside of the scope of this PR but I think that only one of GetAllRoutes and NewExportProxyRoute should be exported (maybe the first one).
Currently, NewExportProxyRoute is exported to allow the usage in the kubevirt_test file, which does not look so good to me :)

[fossedihelm]

missing header

[fossedihelm]

Should it be components_test?

[awels]

Either block or redirect are options. I am just following what other similar routes do, and they do redirect so I did the same. Let me add the header and change the package name.

[fossedihelm]

Either block or redirect are options. I am just following what other similar routes do, and they do redirect so I did the same. Let me add the header and change the package name.

Fair enough! Thank you!
/lgtm

[alicefr]

Looks good, thanks!
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alicefr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alicefr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-commenter-bot]

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator

[awels]

/cherrypick release-1.3

[kubevirt-bot]

@awels: new pull request created: #12226

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[awels]

/cherrypick release-1.2

[kubevirt-bot]

@awels: new pull request created: #12227

In response to this:

/cherrypick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[awels]

/cherrypick release-1.1

[kubevirt-bot]

@awels: #12195 failed to apply on top of branch "release-1.1":

Applying: Ensure virt-export route has redirect policy
Using index info to reconstruct a base tree...
M	pkg/virt-operator/resource/generate/components/BUILD.bazel
Falling back to patching base and 3-way merge...
Auto-merging pkg/virt-operator/resource/generate/components/BUILD.bazel
CONFLICT (content): Merge conflict in pkg/virt-operator/resource/generate/components/BUILD.bazel
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure virt-export route has redirect policy
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.