Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claims: Retry in case the claim get failed #42

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Jul 9, 2024

What this PR does / why we need it:
In case we try to create a claim, and it already exists, and then we try to fetch it in order to validate it, but it was deleted meanwhile, we should retry to reconcile, in order to give it another chance to be created.

Also no need to double check err != nil, as we check it already in this block.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 9, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Jul 16, 2024

/cc @maiqueb @qinqon
can you please take a look ? no rush, thanks

Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@maiqueb
Copy link
Collaborator

maiqueb commented Jul 16, 2024

I'll leave to @qinqon to stamp the approval.

@maiqueb
Copy link
Collaborator

maiqueb commented Jul 16, 2024

Maybe consider rebasing ?

In case we try to create a claim, and it already exists,
and then we try to fetch it in order to validate it,
but it was deleted meanwhile, we should retry to reconcile,
in order to give it another chance to be created.

Also no need double check err != nil, as we check it already in this block.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Jul 16, 2024

rebased

btw we can do that git actions does rebase itself,
and i think Quique did that rebase is mandatory for merging (github enforcing), but we didn't test if it works yet

@maiqueb
Copy link
Collaborator

maiqueb commented Jul 16, 2024

rebased

btw we can do that git actions does rebase itself, and i think Quique did that rebase is mandatory for merging (github enforcing), but we didn't test if it works yet

All I saw was a button to Update branch ...

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@kubevirt-bot kubevirt-bot merged commit ef0ec97 into kubevirt:main Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants