-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
claims: Retry in case the claim get failed #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tks
I'll leave to @qinqon to stamp the approval. |
Maybe consider rebasing ? |
In case we try to create a claim, and it already exists, and then we try to fetch it in order to validate it, but it was deleted meanwhile, we should retry to reconcile, in order to give it another chance to be created. Also no need double check err != nil, as we check it already in this block. Signed-off-by: Or Shoval <oshoval@redhat.com>
rebased btw we can do that git actions does rebase itself, |
All I saw was a button to /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maiqueb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
In case we try to create a claim, and it already exists, and then we try to fetch it in order to validate it, but it was deleted meanwhile, we should retry to reconcile, in order to give it another chance to be created.
Also no need to double check err != nil, as we check it already in this block.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: