Add VM and VMI persistent IPs e2e tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
force-pushed
the
e2e
branch
5 times, most recently
from
1b16199
to
aa58640
Compare
qinqon
force-pushed
the
e2e
branch
6 times, most recently
from
9f1822c
to
09eeb5b
Compare
maiqueb
reviewed
Jun 10, 2024
qinqon
force-pushed
the
e2e
branch
8 times, most recently
from
e71f7d6
to
f99e989
Compare
qinqon
force-pushed
the
e2e
branch
4 times, most recently
from
2f56d62
to
3e08f16
Compare
maiqueb
requested changes
Jun 11, 2024
maiqueb
reviewed
Jun 11, 2024
maiqueb
reviewed
Jun 11, 2024
maiqueb
reviewed
Jun 11, 2024
maiqueb
reviewed
Jun 11, 2024
maiqueb
reviewed
Jun 11, 2024
qinqon
force-pushed
the
e2e
branch
2 times, most recently
from
9a8f232
to
29496c5
Compare
|
/cc @oshoval Can you take a look ? |
oshoval
reviewed
Jun 13, 2024
oshoval
reviewed
Jun 16, 2024
There was a problem hiding this comment.
Very nice
PR desc typo "vm restasrt"
EDIT - about CNAO stuff, i will do it on a follow-up unless you want to do the important ones already
(only #20 (comment) is the most important)
oshoval
reviewed
Jun 16, 2024
|
once it is merged, we would need please a new tag, so we can consume it on CNAO |
oshoval
reviewed
Jun 17, 2024
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scripts to start the ovn-k kind cluster and also add the following e2e tests: