Add controller logic #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
We are not deploying a webhook, so this can be removed. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
add-controller-logic
branch
2 times, most recently
from
71b12de
to
0f382d7
Compare
Adds the base of the KubeVirt VM controller that creates the IPAMClaims for the VMs. It reads the NAD configuration, and for the NADs having the persistent ips feature enabled, it creates the corresponding requested IPAMClaim. Follow-up commits will handle more advanced use-cases, like hotplug, and so forth. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
This commit ensure that an existing IPAMClaim for a VM acually belongs to the VM being reconciled (and not for a different VM with the same name). It relies on the owner reference UID to ensure it. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
add-controller-logic
branch
from
e0f2d23
to
a8198e4
Compare
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
add-controller-logic
branch
from
a8198e4
to
eecabd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.