Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new warning for kubernetes deb/RPM packages migration #44109

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Nov 27, 2023

Previously we only had a vague warning that users should migrate as soon as possible. We now have a more concrete (though technically approximate) timeline that they must migrate before January 2024 and should re-emphasize this change.

Technically the project could redirect these old apt.kubernetes.io and yum.kubernetes.io endpoints to a static snapshot but that will take time, effort, and resources and it's not clear as a project that we should continue to do this versus moving forward with the new community managed host, so in the meantime we should warn that the endpoints as-is will stop working.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2023
@BenTheElder
Copy link
Member Author

/check-cla

@BenTheElder BenTheElder changed the title [WIP] Add new warning for kubernetes deb/RPM packages migration Add new warning for kubernetes deb/RPM packages migration Nov 27, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
@BenTheElder
Copy link
Member Author

/hold
Would like thorough review and a chance for further discussion before this merges, at the same time though we do need to get this notice out ASAP unless we're really confident that *.kubernetes.io redirects to a different backing copy will happen in time.

@mrbobbytables
Copy link
Member

lgtm with steering hat on, should push to get this out there asap with so little time before the turndown

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Nov 27, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 27, 2023
Copy link

netlify bot commented Nov 27, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 68047be
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6568defc7dac120008562938
😎 Deploy Preview https://deploy-preview-44109--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@utkarsh-singh1
Copy link
Contributor

Seems like a build timeout -

Screenshot_20231128_101844

@sftim
Copy link
Contributor

sftim commented Nov 28, 2023

/committee steering

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Nov 28, 2023
Comment on lines +217 to +219
The legacy Linux package repositories (`apt.kubernetes.io` and `yum.kubernetes.io` AKA `packages.cloud.google.com`)<br/>
have been frozen starting from September 13, 2023 **and are going away in January 2024**, users *must* migrate.<br/>
Please read our [announcement](/blog/2023/08/31/legacy-package-repository-deprecation/) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need this, can we schedule (and announce) some brownouts, where we briefly change the DNS domains to point to a simple thing returning a 5xx response?

I'd prefer to have a whole new blog article about the shutdown if needed and if feasible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The *.kubernetes.io could have brownouts but there's not a lot of time left to implement this and we already urged users to switch.

The project took too long to move off of legacy rapture.

don't really have the bandwidth for a whole new post and this has all the info and already told users they should switch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also don't need the announcement if the project pivots to a static mirror but that work still isn't complete and we're cutting it terribly close at this point on warning people with a real deadline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to see what appetite the K8s infra SIG have for a smoother transition. I think lots of people like the idea, and only a few people would be willing to offer time to help.

Copy link
Member Author

@BenTheElder BenTheElder Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about the timeframe, leads from release and infra + anyone they/we looped in have known about the looming shutdown for O(months) and the need to migrate off for O(years), we only have ~1 month left to warn users in the case that a replacement is not working by then ...

@ameukam
Copy link
Member

ameukam commented Nov 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 61babf231690999112e916dacd710593a96a7cb5

@pohly
Copy link
Contributor

pohly commented Nov 30, 2023

👍 from me.

@BenTheElder
Copy link
Member Author

/approve
The banner is approved by steering by simple majority: #44109 (comment)

@pohly
Copy link
Contributor

pohly commented Dec 1, 2023

/approve

For steering.

@natalisucks
Copy link
Contributor

hi @BenTheElder and @pohly – the Kubernetes website has a different list of approvers, which you can always tag when needed by using @kubernetes/sig-docs-en-owners.

/approve for docs

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

@BenTheElder
Copy link
Member Author

BenTheElder commented Dec 1, 2023

hi @BenTheElder and @pohly – the Kubernetes website has a different list of approvers, which you can always tag when needed by using @kubernetes/sig-docs-en-owners.

Right, sorry, I asked steering members to approve the banner specifically, we need to approve that part and our own approval process involves a majority vote. I wanted to make sure that was clear, but it's not intended to cover the blog post or the rest of this repo.

@dims
Copy link
Member

dims commented Dec 1, 2023

/approve
/lgtm

Yes please!

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit ccf51df into kubernetes:main Dec 1, 2023
6 checks passed
@BenTheElder BenTheElder deleted the packages-update branch December 1, 2023 18:07
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated /approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, justaugustus, natalisucks, pacoxu, pohly, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.