Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade capi kubekins-e2e version to 1.26 for presubmit jobs #28337

Merged

Conversation

aniruddha2000
Copy link
Contributor

part of: kubernetes-sigs/cluster-api#7671

Signed-off-by: Aniruddha Basak codewithaniruddha@gmail.com

Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 2, 2023
@sbueringer
Copy link
Member

@aniruddha2000 Just fyi. Please mention me and fabrizio on test-infra PRs. We can't watch for all PRs on the test-infra repo and we are not always getting assigned automatically.

@aniruddha2000
Copy link
Contributor Author

@sbueringer sure I will do it from the next time.

@sbueringer
Copy link
Member

Yup, no worries. Just wanted to let you know in case you're waiting for feedback and we're not aware :)

Reviewed the PR now. Looks good. Let's start merging

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aniruddha2000, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit f57fd60 into kubernetes:master Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

@aniruddha2000: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

In response to this:

part of: kubernetes-sigs/cluster-api#7671

Signed-off-by: Aniruddha Basak codewithaniruddha@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants