Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: clean up stale kubekins tags #23543

Merged
merged 6 commits into from
Sep 10, 2021
Merged

config/jobs: clean up stale kubekins tags #23543

merged 6 commits into from
Sep 10, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 10, 2021

Related:

This addresses a number of job definitions, scripts or docs that use stale kubekins tags. Then update the job image autobump config to catch these in the future

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/prow Issues or PRs related to prow area/prow/spyglass Issues or PRs related to prow's spyglass UI labels Sep 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 10, 2021

FYI @kubernetes/release-engineering
for the pull-k8sio-backup job change
/cc @pohly @msau42
FYI for the kubernetes-csi job changes
/cc @dims @ameukam

justaugustus
justaugustus reviewed Sep 10, 2021
View reviewed changes
config/jobs/README.md
@@ -139,7 +139,7 @@ periodics:
path_alias: "sigs.k8s.io/cluster-api-provider-aws"
spec:
containers:
- image: gcr.io/k8s-testimages/kubekins-e2e:v20200428-06f6e3b-1.15
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20210902-e4567b8-master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If k8s-staging-test-infra is preferred to k8s-testimages, should we update references everywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the next PR, I wanted to avoid burying the little tag cleanups in large search-replace PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is solely for kubekins right now, not all of the other images have been migrated

@spiffxp spiffxp mentioned this pull request Sep 10, 2021
Merged
@spiffxp spiffxp mentioned this pull request Sep 10, 2021
Merged
@ameukam
Copy link
Member

ameukam commented Sep 10, 2021

/lgtm
/hold
Remove hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 10, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1695ead into kubernetes:master Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 10, 2021
@spiffxp spiffxp deleted the kubekins-replacements branch September 10, 2021 15:56
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key container-image-promoter.yaml using file config/jobs/kubernetes/sig-release/cip/container-image-promoter.yaml

In response to this:

Related:

This addresses a number of job definitions, scripts or docs that use stale kubekins tags. Then update the job image autobump config to catch these in the future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 10, 2021
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus left review comments

@chases2 chases2 Awaiting requested review from chases2

@fejta fejta Awaiting requested review from fejta

@ameukam ameukam Awaiting requested review from ameukam

@dims dims Awaiting requested review from dims

@msau42 msau42 Awaiting requested review from msau42

@pohly pohly Awaiting requested review from pohly

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/prow/spyglass Issues or PRs related to prow's spyglass UI area/prow Issues or PRs related to prow area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @k8s-ci-robot @ameukam @justaugustus