Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to SVG #197

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Switch to SVG #197

merged 1 commit into from
Jun 21, 2016

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Jun 21, 2016

  • Switch to SVG for higher quality text, using GCS's gzip content stream feature to reduce file size to 300K instead of 4M.
  • Copy image to old uri until next submit queue push
  • Change 7 PRs queued to Queued PRs: 7 to better match labels on other graphs

Example output:

@ixdy
Copy link
Member

ixdy commented Jun 21, 2016

Both of your linked examples are PNGs - was that intentional?

@fejta
Copy link
Contributor Author

fejta commented Jun 21, 2016

Yes, after this is in we're going to switch the extension of the uri to match the new content-type.

lavalamp
lavalamp reviewed Jun 21, 2016
View reviewed changes
queue-health/graph.py
proc = subprocess.Popen(
['gsutil', '-q',
'-h', 'Content-Type:image/png',
'-h', 'Content-Type:image/svg+xml',
'-h', 'Cache-Control:public, max-age=60',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's 60 seconds, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@lavalamp
Copy link
Member

lgtm but I'll let Ryan weigh in :)

@rmmh rmmh merged commit 71170f9 into kubernetes:master Jun 21, 2016
@davidopp davidopp mentioned this pull request Feb 28, 2017
Closed
@AishSundar AishSundar mentioned this pull request May 18, 2018
Merged
simonswine pushed a commit to simonswine/test-infra that referenced this pull request Jun 4, 2018
@munnerz
Merge pull request kubernetes#197 from jetstack/tarmak-skip
ca4efb3 
Enable skip plugin for tarmak
mborsz pushed a commit to mborsz/test-infra that referenced this pull request Dec 14, 2018
@k8s-ci-robot
Merge pull request kubernetes#197 from krzysied/cluster_loader_params…
93d841c 
…_parsing_fix

ClusterLoader - Int and float parsing fix
MushuEE pushed a commit to MushuEE/test-infra that referenced this pull request Mar 17, 2022
@timburks
minor improvements to generator code (kubernetes#197)
ce28748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rmmh rmmh

@lavalamp lavalamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fejta @ixdy @lavalamp @rmmh @googlebot