Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang version used in gcb-docker-gcloud #17299

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Bump golang version used in gcb-docker-gcloud #17299

merged 1 commit into from
Apr 20, 2020

Conversation

dims
Copy link
Member

@dims dims commented Apr 20, 2020

  • Bump golang version to 1.13.5 (1.12.x is old!)
  • parameterize GO_VERSION in cloudbuild to help with bulk updates when
    other images are being updated
  • pass the GO_VERSION to the Dockerfile and use the specific verion of
    golang alpine image.

Signed-off-by: Davanum Srinivas davanum@gmail.com

@dims
Bump golang version used in gcb-docker-gcloud
166e9a2 
- parameterize GO_VERSION in cloudbuild to help with bulk updates when
other images are being updated
- pass the GO_VERSION to the Dockerfile and use the specific verion of
golang alpine image.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 20, 2020
@dims
Copy link
Member Author

dims commented Apr 20, 2020

/assign @stevekuznetsov @spiffxp

@dims dims mentioned this pull request Apr 20, 2020
Merged
@stevekuznetsov
Copy link
Contributor

/lgtm

@spiffxp
Copy link
Member

spiffxp commented Apr 20, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6959395 into kubernetes:master Apr 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@spiffxp spiffxp

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @stevekuznetsov @spiffxp @k8s-ci-robot