Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image Push Job For Kubernetes CSI #16942

Merged
merged 2 commits into from
Apr 1, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions config/jobs/image-pushing/k8s-staging-csi.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
postsubmits:
# This is the github repo we'll build from. This block needs to be repeated
# for each repo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we'll probably want to have a generator script for all the various repos. There are too many to of them to create and maintain this file manually. But for now as a test it's okay.

kubernetes-csi/node-driver-registrar:
# The name should be changed to match the repo name above
- name: post-node-driver-registrar-push-images
cluster: test-infra-trusted
annotations:
# This is the name of some testgrid dashboard to report to.
testgrid-dashboards: sig-storage-csi-node-driver-registrar
decorate: true
branches:
# For publishing canary images
- ^master$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining that this is for publishing the "canary" images, something that we only do on the master branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment

# this is a regex for semver, from https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string
- ^v(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$
spec:
serviceAccountName: deployer # TODO(fejta): use pusher
containers:
- image: gcr.io/k8s-testimages/image-builder:v20200114-6d2c483
command:
- /run.sh
args:
# this is the project GCB will run in, which is the same as the GCR
# images are pushed to.
- --project=k8s-staging-csi
# This is the same as above, but with -gcb appended.
- --scratch-bucket=gs://k8s-staging-csi-gcb
- --env-passthrough=PULL_BASE_REF
- .