Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 CI!!! (using kind) #13123

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

BenTheElder
Copy link
Member

finally @aojea :-)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2019
@BenTheElder
Copy link
Member Author

/assign @Katharine

@Katharine
Copy link
Member

Have you considered using testgrid annotations on your prowjob?

annotations:
  testgrid-tab-name: kind (IPv6), master (dev)
  testgrid-dashboards: conformance-kind, conformance-all, sig-testing-kind
  testgrid-alert-email: bentheelder@google.com
  description: Runs conformance tests using kubetest against latest kubernetes master with a kubernetes-in-docker cluster

You wouldn't even need the test group definition if it weren't for num_columns_recent: 3 (which can't be specified by annotation).

That said, if you are not so inclined:
/approve
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14190c73ca223eb84a845d1551335ab7f55a0e1c

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@BenTheElder
Copy link
Member Author

You wouldn't even need the test group definition if it weren't for num_columns_recent: 3 (which can't be specified by annotation).

I do want the num_colums_recent though for some of these jobs 😞
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2019
@aojea
Copy link
Member

aojea commented Jun 21, 2019

Go go go go go :-)

@k8s-ci-robot k8s-ci-robot merged commit 5cc97ee into kubernetes:master Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default using the following files:

  • key kind.yaml using file config/jobs/kubernetes-sigs/kind/kind.yaml

In response to this:

finally @aojea :-)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the ipv6-ci-finally branch June 21, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants