Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all cluster-api images to latest kubekins-e2e 1.15 #13113

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Update all cluster-api images to latest kubekins-e2e 1.15 #13113

merged 1 commit into from
Jun 21, 2019

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Jun 21, 2019 •
edited
Loading

Signed-off-by: Vince Prignano vincepri@vmware.com

Go 1.12 is required for kubernetes-sigs/cluster-api#1054

@vincepri
Update all cluster-api images to latest kubekins-e2e 1.15
04a23a4 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2019
@vincepri
Copy link
Member Author

/assign @detiber

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2019
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 21, 2019
@vincepri vincepri mentioned this pull request Jun 21, 2019
Merged
@vincepri
Copy link
Member Author

/assign @ncdc

@ncdc
Copy link
Member

ncdc commented Jun 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9fedb6a476166dca12201d99f55115a5832fc8c9

@k8s-ci-robot k8s-ci-robot merged commit 7f8fc1e into kubernetes:master Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

@vincepri: Updated the job-config configmap in namespace default using the following files:

  • key cluster-api-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml

In response to this:

Signed-off-by: Vince Prignano vincepri@vmware.com

Go 1.12 is required for kubernetes-sigs/cluster-api#1054

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@ncdc ncdc

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincepri @k8s-ci-robot @ncdc @detiber