Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the kic base image version to the output #17739

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add the kic base image version to the output #17739

merged 1 commit into from
Dec 12, 2023

Conversation

afbjorklund
Copy link
Collaborator

Helps with troubleshooting KIC problems: #17700 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
medyagh
medyagh reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afbjorklund do you mind pasting the out pf minikube start I am curious how the formatting looks like?

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Dec 7, 2023 •
edited
Loading 

👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image v0.0.42-1701387262-17703 ...
💾  Downloading Kubernetes v1.28.4 preload ...

@medyagh
Copy link
Member

medyagh commented Dec 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 8, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime
error downloading artifacts: artifact download start: exit status 90docker driver with docker runtime
error downloading artifacts: artifact download start: exit status 81docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 81

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 1.19 (chart)
KVM_Linux_crio TestPause/serial/SecondStartNoReconfiguration (gopogh) 47.02 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit e2deef5 into kubernetes:master Dec 12, 2023
37 of 51 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@spowelljr spowelljr spowelljr approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afbjorklund @medyagh @minikube-pr-bot @k8s-ci-robot @spowelljr