Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #83685: add allowunsafe read #84569

Closed
wants to merge 3 commits into from
Closed

Automated cherry pick of #83685: add allowunsafe read #84569

wants to merge 3 commits into from

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 30, 2019 •
edited
Loading

Cherry pick of #83685 on release-1.13.

#83685: add allowunsafe read

For details on the cherry pick process, see the cherry pick requests page.

Partially resolves
kubernetes-sigs/cloud-provider-azure#247

azure: Add allow unsafe read from cache

@aramase
add allowunsafe read
9f77627 
update common controller

add comment

update to cached data

add cacheReadType type

update logic for disk reconcile loop to read from cache

update delete cache for node

review feedback
@aramase
update getmetadata to use unsafe read
3cd66d0
@k8s-ci-robot
Copy link
Contributor

@aramase: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS.
For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aramase
To complete the pull request process, please assign karataliu
You can assign the PR to them by writing /assign @karataliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aramase aramase force-pushed the automated-cherry-pick-of-#83685-upstream-release-1.13 branch from f7c41d9 to 09f984f Compare October 30, 2019 19:36
@aramase
Copy link
Member Author

aramase commented Oct 30, 2019

/kind bug
/area provider/azure

/hold
(waiting for soak test results, will remove hold after)

cc @lachie83 @khenidak

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. area/provider/azure Issues or PRs related to azure provider and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 30, 2019
@aramase
add cache read type prefix for const
4a074d1 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the automated-cherry-pick-of-#83685-upstream-release-1.13 branch from 09f984f to 4a074d1 Compare October 30, 2019 19:49
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 30, 2019
@aramase
Copy link
Member Author

aramase commented Oct 30, 2019

/test pull-kubernetes-e2e-gce-device-plugin-gpu

1 similar comment
@aramase
Copy link
Member Author

aramase commented Oct 30, 2019

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@k8s-ci-robot
Copy link
Contributor

@aramase: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 4a074d1 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aramase
Copy link
Member Author

aramase commented Oct 31, 2019

Closing this PR as 1.13 is no longer supported.

@aramase aramase closed this Oct 31, 2019
@aramase aramase deleted the automated-cherry-pick-of-#83685-upstream-release-1.13 branch October 31, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@khenidak khenidak Awaiting requested review from khenidak

Assignees
No one assigned
Labels
area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aramase @k8s-ci-robot