Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to schemaless apply behavior for custom resources with unhandled schemas #82438

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 6, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Falls back to schema-less behavior for server-side-apply for custom resources defined with schemas that are not handled by kube-openapi.

An inability to construct the schema for server-side-apply to use should not block serving of existing CRDs

Which issue(s) this PR fixes:
Fixes #82436

Does this PR introduce a user-facing change?:

Resolved regression serving custom resources with unhandled validation schemas with the ServerSideApply feature enabled

/sig api-machinery
/cc @apelisse @jennybuckley @sttts
/milestone v1.16
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 6, 2019
@jennybuckley
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@liggitt
Copy link
Member Author

liggitt commented Sep 6, 2019

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Sep 6, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit e682310 into kubernetes:master Sep 6, 2019
@liggitt liggitt deleted the apply-fallback branch September 9, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in v1.16.0-beta.2 - the server could not properly serve the CR schema
3 participants