Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups: add SIG-Storage members to k8s-infra-staging-csi #768

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Apr 20, 2020

Right now, none of the people involved with SIG-Storage have access to
logs when staging
fails (kubernetes/test-infra#16942 (comment)). As
suggested in that
discussion (kubernetes/test-infra#16942 (comment)),
I am adding the current SIG chairs and tech leads plus myself as
someone who has been working on image publishing.

/cc @saad-ali @msau42 @xing-yang @jsafrane

Right now, none of the people involved with SIG-Storage have access to
logs when staging
fails (kubernetes/test-infra#16942 (comment)). As
suggested in that
discussion (kubernetes/test-infra#16942 (comment)),
I am adding the current SIG chairs and tech leads plus myself as
someone who has been working on image publishing.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. wg/k8s-infra labels Apr 20, 2020
@msau42
Copy link
Member

msau42 commented Apr 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2020
@xing-yang
Copy link
Contributor

/lgtm

@jsafrane
Copy link
Member

/lgtm

@spiffxp
Copy link
Member

spiffxp commented Apr 23, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 74f1e0b into kubernetes:master Apr 23, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 23, 2020

Ran make run -- --confirm in groups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants