lint: break out of loop, not just out of select statement #785
Conversation
Caught by staticcheck: main.go:2083:5: ineffective break statement. Did you mean to break out of the outer loop? (SA4011)
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
| @@ -2077,10 +2077,11 @@ func parseGitConfigs(configsFlag string) ([]keyVal, error) { | |||
| ch := make(chan rune) | |||
| stop := make(chan bool) | |||
| go func() { | |||
| loopOverConfigFlags: | |||
There was a problem hiding this comment.
yes, BUT....this whole function is borked. We never send stop, so we leave a dangling goroutine. I only vaguely recall this code, and frankly, I am not sure what I was thinking. I think this can be much simpler.
Adding leak detection to the test proves it.
I'm going to close this and send a different one which doesn't leak.
Caught by staticcheck:
main.go:2083:5: ineffective break statement. Did you mean to break out of the outer loop? (SA4011)