Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TaintBasedEvictions GA kep from scheduling to node #1510

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Jan 27, 2020

This was erroneously merged under sig-scheduling, but it should be under sig-node

See kubernetes/kubernetes#87487 (comment)

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2020
@damemi
Copy link
Contributor Author

damemi commented Jan 27, 2020

/cc @ahg-g @Huang-Wei
Do you have a link to the comment where we pointed out that this should be moved? I seem to have lost it

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 27, 2020
@damemi damemi mentioned this pull request Jan 27, 2020
@ahg-g
Copy link
Member

ahg-g commented Jan 27, 2020

/cc @ahg-g @Huang-Wei
Do you have a link to the comment where we pointed out that this should be moved? I seem to have lost it

We talked about it offline. kubernetes/kubernetes#87487 (comment)

The approving sig is sig-node so naturally it should be placed under sig-node KEPs.

@damemi
Copy link
Contributor Author

damemi commented Jan 27, 2020

Does this need to merge by enhancement freeze (tomorrow)? Technically this KEP already merged and passed the enhancement freeze requirements, it's just under the wrong folder, right?

@damemi
Copy link
Contributor Author

damemi commented Jan 28, 2020

Other discussion that this would be better suited under sig-apps: kubernetes/kubernetes#87427 (comment)

@fengzixu
Copy link

Other discussion that this would be better suited under sig-apps: kubernetes/kubernetes#87427 (comment)

Ok. Got it

@damemi
Copy link
Contributor Author

damemi commented Feb 11, 2020

We've decided to keep this under sig-node (kubernetes/kubernetes#87427 (comment)). So, bumping, can this merge?

@damemi
Copy link
Contributor Author

damemi commented Feb 25, 2020

Bumping, can this be merged to move the KEP to sig-node? I believe we've reached a consensus at this point that this should be there

@damemi
Copy link
Contributor Author

damemi commented Mar 3, 2020

/assign @derekwaynecarr
Can you approve this move? Currently this blocks the 3 PRs that are ready to get this enhancement merged by code freeze

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit ffcab6d into kubernetes:master Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants