-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle reservation capacity exceeded error separately #7319
Handle reservation capacity exceeded error separately #7319
Conversation
|
Welcome @norbertcyran! |
Hi @norbertcyran. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9766022
to
78dccb0
Compare
@@ -93,7 +97,6 @@ var ( | |||
regexp.MustCompile("Reservation (.*) is incorrect for the requested resources"), | |||
regexp.MustCompile("Zone does not currently have sufficient capacity for the requested resources"), | |||
regexp.MustCompile("Reservation (.*) does not have sufficient capacity for the requested resources."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this one also go under RESERVATION_CAPACITY_EXCEEDED?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking about it with @mtrqq -- this is the old error message, it's left here in case of rollbacks. However, I think we should remove that line soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'll remove it now.
78dccb0
to
27dcba4
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel, norbertcyran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Handle errors related to exceeded capacity in reservation separately in order to give a better visibility to the user
Does this PR introduce a user-facing change?