Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send event on successful provisioning #51

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Aug 2, 2019

With the old backoffStore, the provisioner sent "Successfully provisioned volume XYZ" event after saving PV. This PR adds the same event to the new queueStore, so users see that provisioning has finished.

Without this PR, PVC events look a bit confusing:

$ kubectl describe pvc
Name:          myclaim
...
Status:        Bound
...
  Normal  WaitForFirstConsumer   11s   persistentvolume-controller                                                            waiting for first consumer to be created before binding
  Normal  ExternalProvisioning   11s   persistentvolume-controller                                                            waiting for a volume to be created, either by external provisioner "io.kubernetes.storage.mock" or manually created by system administrator
  Normal  Provisioning           11s   io.kubernetes.storage.mock_localhost.localdomain_4a8de503-b51a-11e9-ab3e-52540004020e  External provisioner is provisioning volume for claim "default/myclaim"

So is it Bound or External provisioner is provisioning volume?

This restores event "Successfully provisioned volume XYZ" when saving queue
is used.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2019
@wongma7
Copy link
Contributor

wongma7 commented Aug 2, 2019

/lgtm
cool

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit a82cca0 into kubernetes-sigs:master Aug 2, 2019
jsafrane added a commit to jsafrane/external-provisioner that referenced this pull request Aug 5, 2019
humblec pushed a commit to humblec/sig-storage-lib-external-provisioner that referenced this pull request Jun 18, 2020
Enable topology testing with hostpath driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants