-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apparmor recorder: add hugepage support #2421
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
==========================================
- Coverage 45.50% 41.85% -3.65%
==========================================
Files 79 109 +30
Lines 7782 16020 +8238
==========================================
+ Hits 3541 6705 +3164
- Misses 4099 8816 +4717
- Partials 142 499 +357 |
CI is failing because the macOS CI runner does not have |
I think so, that's why we added the build job. Do you mind fixing the build? |
Fixed! :) |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhils, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes our AppArmor recorder to detect anonymous huge table usage and work around related AppArmor limitations. This is slightly ugly, but all other workarounds are even more ugly.
Which issue(s) this PR fixes:
None
Does this PR have test?
Yes
Does this PR introduce a user-facing change?