-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to Go v1.21 #5555
Conversation
In my experience, that is better to run |
|
Rebased and fixed plugin generation. In order for the prow test to pass in prow, the prow config needs to be updated to support Go 1.21: kubernetes/test-infra#31974 |
/retest |
Hi @karlkfi |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- go mod tidy (all modules) - go work sync - Fixed plugin generation for Go 1.21 - Updated linting for Go 1.21 - Fixed minecraft example for Helm v3 pull download path - Update dev docs to mention Go 1.21 - Regenerate plugins with Go 1.21
Rebased and passed all test! |
(Rebasing these is a pain, cause it conflicts with every go.mod and go.sum change.) |
Thanks! I'll review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your hard work! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, koba1t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Includes:
Depends on kubernetes/test-infra#31974
Blocking #5535