Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate i2gw.InputResources #141

Merged

Conversation

YTGhost
Copy link
Contributor

@YTGhost YTGhost commented Mar 8, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Deprecate i2gw.InputResources
  • Remove input resources from ToGatewayAPI function.

Which issue(s) this PR fixes:

Fixes #113

Does this PR introduce a user-facing change?:

Deprecate `i2gw.InputResources` and remove input resources from `ToGatewayAPI` function

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 8, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @YTGhost. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 8, 2024
@YTGhost
Copy link
Contributor Author

YTGhost commented Mar 8, 2024

Hi @LiorLieberman PTAL

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2024
Signed-off-by: Liang Deng <283304489@qq.com>
@YTGhost YTGhost force-pushed the feat-deprecate-inputResources branch from ec10407 to 90a2357 Compare March 13, 2024 03:48
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2024
@LiorLieberman
Copy link
Member

LiorLieberman commented Mar 27, 2024

Thats awesome, thank you @YTGhost !
/ok-to-test

In the meantime, please update the release notes

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2024
@YTGhost
Copy link
Contributor Author

YTGhost commented Mar 27, 2024

Thats awesome, thank you @YTGhost ! /ok-to-test

In the meantime, please update the release notes

Sure

@mlavacca
Copy link
Member

mlavacca commented Apr 2, 2024

/cc @mlavacca

Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me.
/cc @levikobi @mlavacca can you please take a look?

Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YTGhost
This is quite a big change so I played around with this for a bit. I Couldn't find something that broke and tests are passing so lgtm.

@mlavacca if you could take a look as well it would be great
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@LiorLieberman
Copy link
Member

/cc @mlavacca can you take a look at this?

Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks YTGhost!

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 11f5ee2 into kubernetes-sigs:main May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a good use of i2gw.InputResources or deprecate it
5 participants