Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parallel test. #273

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Fix parallel test. #273

merged 1 commit into from
Mar 20, 2018

Conversation

Random-Liu
Copy link
Contributor

This PR:

  1. Fixes parallel test. We didn't pass non-ginkgo flags.
  2. Change image-endpoint to use runtime-endpoint by default.

Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu
Fix parallel test.
50abade 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2018
@Random-Liu Random-Liu added this to the v1.0.0-beta.0 milestone Mar 20, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 20, 2018
feiskyer
feiskyer reviewed Mar 20, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2018
@feiskyer feiskyer merged commit 976680c into kubernetes-sigs:master Mar 20, 2018
@Random-Liu Random-Liu deleted the fix-parallel-test branch March 20, 2018 17:24
@thaJeztah thaJeztah mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Random-Liu @feiskyer @k8s-ci-robot