Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate: support old ipcmk versions #197

Merged
merged 1 commit into from
Nov 21, 2017
Merged

validate: support old ipcmk versions #197

merged 1 commit into from
Nov 21, 2017

Conversation

runcom
Copy link
Contributor

@runcom runcom commented Nov 20, 2017 •
edited
Loading

ipcmk fails on RHEL with:

ipcmk: failed to parse size: '1MB'

Since it's version 2.23.2. This patch changes the invocation to ipcmk so we can run critest on RHEL by using 1024 * 1024.

@feiskyer @Random-Liu @mrunalp PTAL

Signed-off-by: Antonio Murdaca runcom@redhat.com

@runcom
validate: support old ipcmk versions
938fa3c 
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2017
@runcom runcom mentioned this pull request Nov 20, 2017
Merged
mrunalp
mrunalp approved these changes Nov 20, 2017
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2017
feiskyer
feiskyer approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks

@feiskyer feiskyer merged commit 9fa77be into kubernetes-sigs:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@feiskyer feiskyer feiskyer approved these changes

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@runcom @mrunalp @feiskyer @k8s-ci-robot